Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(es): Translate notifications page into Spanish #3137

Merged
merged 2 commits into from
Feb 8, 2025
Merged

i18n(es): Translate notifications page into Spanish #3137

merged 2 commits into from
Feb 8, 2025

Conversation

gimenete
Copy link
Contributor

@gimenete gimenete commented Jan 27, 2025 •
edited
Loading

Description

Translates the notifications section into Spanish.

Pull request created with GitHero

@gimenete gimenete requested a review from a team as a code owner January 27, 2025 22:35
@github-actions github-actions bot added i18n Is this related to translations? i18n: es Is this related to es translations? labels Jan 27, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 27, 2025 •
edited
Loading

✅ Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 55fde0d
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/67a7abb6e3476400087cea17
😎 Deploy Preview https://deploy-preview-3137--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

paulmelero
paulmelero reviewed Feb 6, 2025
View reviewed changes
Copy link

@paulmelero paulmelero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had an important comment about inclusive language.

Count me in for further revisions. For example, if you continue with the Permission Table.

Thank you for your great i18n work.

@gimenete gimenete requested a review from paulmelero February 7, 2025 22:31
paulmelero
paulmelero approved these changes Feb 8, 2025
View reviewed changes
Copy link

@paulmelero paulmelero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dreyfus92
dreyfus92 approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both! 😁

@dreyfus92 dreyfus92 merged commit a17ad44 into tauri-apps:v2 Feb 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelero paulmelero paulmelero approved these changes

@dreyfus92 dreyfus92 dreyfus92 approved these changes

Assignees

@gimenete gimenete

Labels
i18n: es Is this related to es translations? i18n Is this related to translations?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gimenete @paulmelero @dreyfus92