Make the reset confirmation dialogs user configurable#7
Open
kareandersen wants to merge 1 commit intotattlemuss:hrdb-mainfrom
Open
Make the reset confirmation dialogs user configurable#7kareandersen wants to merge 1 commit intotattlemuss:hrdb-mainfrom
kareandersen wants to merge 1 commit intotattlemuss:hrdb-mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small quality of life improvement: Allows users to reset hatari from hrdb without having to click the confirmation dialog.
Includes a checkbox in preferences and an "opt out" style selector - if the config item was not in the users ini file before, it will be enabled by default so as to not change existing behavior. Could be cleaner with a small helper perhaps, but didn't want to introduce new concepts here.