Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript-Vue #1854

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Typescript-Vue #1854

wants to merge 2 commits into from

Conversation

victorgarciaesgi
Copy link

No description provided.

@Fruitseller
Copy link
Contributor

Hello @victorgarciaesgi do you still want to merge this PR to todomvc?
If so you would need to rebase your branch with the current master 😊
If not it is also okay and we could close this PR. :bowtie:

@victorgarciaesgi
Copy link
Author

Yes still want to! I just need to pull master right?

@Fruitseller
Copy link
Contributor

@victorgarciaesgi I think rebasing would be a cleaner aproach for getting your PR up to date.
You should also look if you codebase fulfills the app requirements.

And I think it would be great if you could write something about your motivations to add vue in TS to todomvc and also what the benefits are when its merged.😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorgarciaesgi @Fruitseller