-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(movies): migrate to use application builder SSR features #281
Conversation
pushed few things:
|
fab502c
to
0bf31a2
Compare
Visit the preview URL for this PR (updated for commit b97d0a8): https://angular-movies-a12d3--update-to-ng17-ssr-3n6ista4.web.app (expires Sun, 07 Apr 2024 12:49:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f5e1819659ee450e0b7241d53391169f76c6f1d4 |
What needs to be fixed: |
@vmasek I'm looking into icon ssr loader now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote it to the commit message, in short you can only specify one config json for deployment and if you split the hosting
and functions
into multiple configs, the hosting will never be associated with the functions rewrites thus SSR will not work correctly
e8ff24a
to
9a89795
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I check and we could do a bit of a cleanup. Will comment more...
related ssr function and hosting need to be together
…s up functions serving
…ersions, enable zoneless, enable view transition api
9a89795
to
550897a
Compare
No description provided.