Skip to content

feat: ported functionality from taskiq-redis #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 5, 2025

Conversation

danfimov
Copy link
Contributor

This pull request contains the core functionality ported from taskiq-redis.

Main changes compared to taskiq-redis:

  • All entities have been renamed from redis to valkey without changing their functionality
  • A different library is used for storage operations: redis-py is replaced with valkey-py
  • Deprecated implementations of RedisScheduleSource and ListQueueBroker were not transferred (consequently, the migration section from the README and the tests for these entities were also not included)

@danfimov
Copy link
Contributor Author

@s3rius I think it's not convenient for contributor to wait approval for starting workflow with tests. Can you tweak CI settings for this repo if it's possible?

@s3rius
Copy link
Member

s3rius commented May 5, 2025

It is convenient, because otherwise random contributor can create a PR and steal your CI secrets. It's security considerations.

@s3rius s3rius merged commit 4734b96 into taskiq-python:master May 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants