Header harmony #1213
Open
Header harmony #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Katrin-kudryash
force-pushed
the
issues/1212
branch
3 times, most recently
from
16eb20e to
e7878bc
Compare
Katrin-kudryash
force-pushed
the
issues/1212
branch
2 times, most recently
from
1c655d3 to
5cff4bf
Compare
tsumo
approved these changes
Dec 26, 2024
Katrin-kudryash
force-pushed
the
issues/1212
branch
2 times, most recently
from
2b18aea to
2d4fd61
Compare
|
|
/canary |
|
Canary available: |
LamaEats
requested changes
Dec 27, 2024
src/harmony/Header/Header.module.css
Outdated
|
|
||
| .HeaderNavLink:hover { | ||
| color: var(--base-white); | ||
| border-color: var(--link0); |
There was a problem hiding this comment.
this prop doesn't exist in css harmony styles
src/harmony/Header/Header.module.css
Outdated
| } | ||
|
|
||
| .HeaderNavLink:active { | ||
| color: var(--link0); |
src/harmony/Link/Link.module.css
Outdated
| .Link_primary { | ||
| color: var(--text-primary); | ||
| text-decoration-line: none; | ||
| } | ||
|
|
||
| .Link_primary:hover { | ||
| color: var(--blue-500); | ||
| color: var(--link0); |
src/harmony/Link/Link.module.css
Outdated
| } | ||
|
|
||
| .Link_inline { | ||
| color: inherit; | ||
| text-decoration-line: underline; | ||
| font-size: var(--link0); |
src/harmony/Link/Link.module.css
Outdated
| @@ -1,19 +1,29 @@ | |||
| .Link { | |||
| transition: color 200ms ease-in; | |||
| font-size: 22px; | |||
There was a problem hiding this comment.
why size in pixels not rems?
src/harmony/Header/Header.tsx
Outdated
|
|
||
| export const HeaderNavLink: FC<AnchorHTMLAttributes<HTMLAnchorElement>> = ({ className, children, ...props }) => { | ||
| return ( | ||
| <a className={cn(s.HeaderNavLink, className)} {...props}> |
There was a problem hiding this comment.
You can use the Link component instead of plain html a element
Katrin-kudryash
force-pushed
the
issues/1212
branch
6 times, most recently
from
8f74065 to
83d2219
Compare
Katrin-kudryash
force-pushed
the
issues/1212
branch
from
83d2219 to
3f9b02a
Compare
LamaEats
approved these changes
Dec 27, 2024
|
/canary |
|
Canary available: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes
Related issues
Resolve #1212