Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing C_INV to use constants #2970

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rohit2p
Copy link

@rohit2p rohit2p commented Feb 13, 2025

📝 Description

Type: 🪲 bugfix

Changing C_INV to use astropy.constants.c to increased precision.

closes: #2616

🚦 Testing

How did you test these changes?

  • Testing pipeline

@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran ruff on the latest commit (c7defc9).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

2	RET505	[ ] Unnecessary `else` after `return` statement
2	F401  	[*] `tardis.opacities.continuum.continuum_state.ContinuumState` imported but unused
1	RET506	[ ] Unnecessary `else` after `raise` statement
1	D202  	[*] No blank lines allowed after function docstring (found 1)

Complete output(might be large):

tardis/spectrum/formal_integral.py:13:56: F401 [*] `tardis.opacities.continuum.continuum_state.ContinuumState` imported but unused
tardis/spectrum/formal_integral.py:15:5: F401 [*] `tardis.opacities.opacity_state.OpacityState` imported but unused
tardis/spectrum/formal_integral.py:359:13: RET506 Unnecessary `else` after `raise` statement
tardis/spectrum/formal_integral.py:424:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/spectrum/formal_integral.py:717:5: RET505 Unnecessary `else` after `return` statement
tardis/spectrum/formal_integral.py:753:5: RET505 Unnecessary `else` after `return` statement
Found 6 errors.
[*] 3 fixable with the `--fix` option.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C_INV in formal_integral should use astropy constants
2 participants