Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger Widget Panel #2872

Open
wants to merge 57 commits into
base: master
Choose a base branch
from

Conversation

atharva-2001
Copy link
Member

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tardis-bot
Copy link
Contributor

tardis-bot commented Nov 11, 2024

*beep* *bop*
Hi human,
I ran ruff on the latest commit (9855204).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

Complete output(might be large):

@atharva-2001 atharva-2001 marked this pull request as ready for review November 15, 2024 08:16
@tardis-bot
Copy link
Contributor

tardis-bot commented Nov 25, 2024

*beep* *bop*

Hi, human.

The docs workflow has failed

Click here to see the build log.

tardis/io/logger/logger.py Outdated Show resolved Hide resolved
tardis/io/logger/logger.py Outdated Show resolved Hide resolved
tardis/io/logger/logger.py Outdated Show resolved Hide resolved
tardis/io/logger/logger.py Outdated Show resolved Hide resolved
tardis/io/logger/logger.py Outdated Show resolved Hide resolved
self.futures = []

# Single event loop and thread for all environments
self.loop = asyncio.new_event_loop()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this to be created for environments outside of a notebook? e.g. what happens if you run TARDIS in the command line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid it creates a new loop there too. Do we want to show the logs in the terminal or do we want to show it as a Panel widget in the browser(it would be deployed on some port)? If it is the first case then I will change it so that this mechanism only works with VSCode and Jupyter Notebooks(since those are the places where we would be seeing the widget). Does that sound alright to you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please make the logs just print to terminal for CLI use of TARDIS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tardis/base.py Outdated Show resolved Hide resolved
tardis_env3.yml Show resolved Hide resolved
@andrewfullard
Copy link
Contributor

I really don't like pinning notebook to an earlier version. There were major improvements in 7.x.

@atharva-2001 atharva-2001 force-pushed the logger_widget_panel branch 3 times, most recently from 72de203 to 5738a20 Compare December 16, 2024 10:30
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 70.19868% with 45 lines in your changes missing coverage. Please review.

Project coverage is 69.33%. Comparing base (5e2d0bb) to head (7a37553).

Files with missing lines Patch % Lines
tardis/io/logger/logger.py 67.85% 45 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2872      +/-   ##
==========================================
- Coverage   69.74%   69.33%   -0.41%     
==========================================
  Files         224      223       -1     
  Lines       16313    16352      +39     
==========================================
- Hits        11377    11338      -39     
- Misses       4936     5014      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants