-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger Widget Panel #2872
base: master
Are you sure you want to change the base?
Logger Widget Panel #2872
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
8902d28
to
75f09b9
Compare
*beep* *bop* Hi, human. The Click here to see the build log. |
tardis/io/logger/logger.py
Outdated
self.futures = [] | ||
|
||
# Single event loop and thread for all environments | ||
self.loop = asyncio.new_event_loop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this to be created for environments outside of a notebook? e.g. what happens if you run TARDIS in the command line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid it creates a new loop there too. Do we want to show the logs in the terminal or do we want to show it as a Panel widget in the browser(it would be deployed on some port)? If it is the first case then I will change it so that this mechanism only works with VSCode and Jupyter Notebooks(since those are the places where we would be seeing the widget). Does that sound alright to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please make the logs just print to terminal for CLI use of TARDIS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, this change does that- 03d34f1#diff-2f4aaca893bcc603dd023f49b86f7243a7a52d1078eec0b6fa5742dd8da8d882
0ab316e
to
8fa0692
Compare
b4f07d3
to
1483ee1
Compare
I really don't like pinning |
72de203
to
5738a20
Compare
ed5cf77
to
5c0fe94
Compare
5c0fe94
to
e41364e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2872 +/- ##
==========================================
- Coverage 69.74% 69.33% -0.41%
==========================================
Files 224 223 -1
Lines 16313 16352 +39
==========================================
- Hits 11377 11338 -39
- Misses 4936 5014 +78 ☔ View full report in Codecov by Sentry. |
d9d6c32
to
497b691
Compare
fccee72
to
02918bc
Compare
3681686
to
9855204
Compare
📝 Description
Type: 🪲
bugfix
| 🚀feature
| ☣️breaking change
| 🚦testing
| 📝documentation
| 🎢infrastructure
Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.
Also, link issues affected by this pull request by using the keywords:
close
,closes
,closed
,fix
,fixes
,fixed
,resolve
,resolves
orresolved
.📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label