Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: add command to list modules #1132

Open
wants to merge 1 commit into
base: dmyger/gh-1014-prepare-modules-list
Choose a base branch
from

Conversation

dmyger
Copy link
Collaborator

@dmyger dmyger commented Mar 24, 2025

It's part of modules support. Introduce modules list sub-command.

I didn't forget about (remove if it is not applicable):

  • Well-written commits
    (see documentation how to write a commit message)
  • Don't forget about TarantoolBot in a commit message
    (see example)
  • Tests (see documentation for a testing package)
  • Changelog (see documentation for changelog format)
  • Documentation (see documentation for documentation style guide)

Related issues:

Closes #1016
Closes #TNTP-1805

@dmyger dmyger force-pushed the dmyger/tntp-1805-modules_list branch from 3a3d7d8 to 7e7559a Compare March 24, 2025 17:41
@dmyger dmyger requested a review from oleg-jukovec March 24, 2025 17:42
@dmyger dmyger marked this pull request as ready for review March 24, 2025 17:42
@dmyger dmyger requested a review from patapenka-alexey March 24, 2025 17:42
@patapenka-alexey
Copy link
Contributor

Please, update commit message.

Closes #1016
Closes #TNTP-1805

@oleg-jukovec
Copy link
Contributor

image
Please, add TarantoolBot message into the commit message and an example of execution into the PR.

Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@dmyger dmyger force-pushed the dmyger/gh-1014-prepare-modules-list branch from 27dcb34 to 5977a15 Compare March 25, 2025 12:38
Closes #1016
Closes #TNTP-1805

@TarantoolBot document
Title: new command to list modules.

`tt modules list` is a new command to show available modules.
It supports extra flags:
* `--version` - to show information about module version.
* `--path` - to show module executables path.

**Usage Example**:
Get simple list of modules with description.
```sh
tt modules list
```

Display modules version with executable entry point.
```sh
tt modules list --version --path
```
@dmyger dmyger force-pushed the dmyger/tntp-1805-modules_list branch from 7e7559a to 847b7ca Compare March 25, 2025 12:54
@dmyger dmyger requested a review from oleg-jukovec March 25, 2025 12:55
@dmyger dmyger added the full-ci Enables full ci tests label Mar 25, 2025
@@ -82,14 +82,9 @@ func getInternalHelpFunc(cmd *cobra.Command, help DefaultHelpFunc) modules.Inter
// of descriptions for external modules.
func getExternalCommandsString(modulesInfo *modules.ModulesInfo) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update comment for this function:
// getExternalCommandsString returns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables full ci tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants