Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for new {{ metricsPort }} construct #1120

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

dmyger
Copy link
Collaborator

@dmyger dmyger commented Mar 10, 2025

The configuration template generation functionality has been extended:

  • Previously, the {{ port }} construct was available for generating cluster configuration files with different ports.
  • A new construct, {{ metricsPort }}, has been added for generating the port of the metrics/metrics-export-role module.

This allows for more flexible configuration of ports for instances.

Based on PR: #1107

@dmyger dmyger requested a review from oleg-jukovec March 10, 2025 11:09
@dmyger dmyger marked this pull request as ready for review March 10, 2025 11:09
@dmyger dmyger requested a review from patapenka-alexey March 10, 2025 11:09
@dmyger dmyger added the full-ci Enables full ci tests label Mar 10, 2025
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is 2 commits instead 1.

The configuration template generation functionality has been extended:

- Previously, the `{{ port }}` construct was available for generating
  cluster configuration files with different ports.
- A new construct, `{{ metricsPort }}`, has been added for generating
  the port of the metrics/metrics-export-role module.

This allows for more flexible configuration of ports for instances.
@dmyger dmyger force-pushed the feature-metrics-port-template-func branch from d46cb27 to eaf88a3 Compare March 10, 2025 11:22
@dmyger
Copy link
Collaborator Author

dmyger commented Mar 10, 2025

There is 2 commits instead 1.

Squashed

@dmyger dmyger merged commit d30eafd into master Mar 10, 2025
24 checks passed
@dmyger dmyger deleted the feature-metrics-port-template-func branch March 10, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables full ci tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants