Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor uninstall #1089

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

refactor uninstall #1089

wants to merge 13 commits into from

Conversation

elhimov
Copy link
Contributor

@elhimov elhimov commented Jan 21, 2025

  • simplify and reuse GetAvailableVersions
  • don't refer config.CliOpts in 'uninstall' package
  • avoid duplication of Command.ValidArgsFunction
  • get program name from cmdCtx rather than using global var
  • remove unused cmdCtx argument
  • make uninstall handler private

Part of #1086

@elhimov elhimov force-pushed the elhimov/gh-1086-refactor-uninstall branch 3 times, most recently from b8cf088 to 68fed4b Compare January 22, 2025 16:48
@elhimov elhimov force-pushed the elhimov/gh-1086-refactor-uninstall branch from 68fed4b to 40df6e5 Compare March 15, 2025 08:14
@elhimov elhimov force-pushed the elhimov/gh-1086-refactor-uninstall branch 2 times, most recently from 1ea93e3 to cfdd425 Compare March 18, 2025 11:27
@elhimov elhimov force-pushed the elhimov/gh-1086-refactor-uninstall branch from cfdd425 to 1275a46 Compare March 18, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elhimov