Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump ubuntu version #330

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patapenka-alexey
Copy link

@patapenka-alexey patapenka-alexey commented Mar 31, 2025

Bump actions to use ubuntu-24.04 for fixing the following GitHub
warning:

The Ubuntu 20.04 Actions runner image will begin deprecation
on 2025-02-01.

Part of #TNTP-1918

@patapenka-alexey patapenka-alexey changed the title Patapenka alexey/tntp 1918 bump ubuntu version ci: bump ubuntu version Mar 31, 2025
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-1918-bump-ubuntu-version branch 8 times, most recently from 6fbb5ce to 5488839 Compare April 2, 2025 08:31
@patapenka-alexey patapenka-alexey marked this pull request as ready for review April 2, 2025 08:46
@@ -103,7 +103,8 @@ jobs:
run: |
curl -L https://tarantool.io/release/2/installer.sh | bash
sudo apt install -y tt
tt rocks install crud
pip3 install cmake==3.15.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a link to the problem.

@@ -103,7 +103,8 @@ jobs:
run: |
curl -L https://tarantool.io/release/2/installer.sh | bash
sudo apt install -y tt
tt rocks install crud
pip3 install cmake==3.15.3
tt rocks install crud 1.4.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you specify a concrete version here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remote. Thanks.

Comment on lines 474 to 475
# - os: ubuntu
# dist: noble # 24.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it commented?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Comment on lines 468 to 469
# - os: debian
# dist: bookworm # 12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Comment on lines -472 to -473
- os: debian
dist: bullseye # 11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why is it deleted?

Copy link
Author

@patapenka-alexey patapenka-alexey Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent such type of error. I still trying find the solution.

Preparing to unpack .../python3-msgpack_1.0.0-6+b1_amd64.deb ...
Unpacking python3-msgpack (1.0.0-6+b1) ...
Selecting previously unselected package python3-tz.
Preparing to unpack .../python3-tz_2021.1-1_all.deb ...
Unpacking python3-tz (2021.1-1) ...
dpkg-deb: error: archive '/__w/tarantool-python/tarantool-python/deb_dist/python3-tarantool_1.2.1.dev14+gec6001d_all.deb' uses unknown compression for member 'control.tar.zst', giving up
dpkg: error processing archive /__w/tarantool-python/tarantool-python/deb_dist/python3-tarantool_1.2.1.dev14+gec6001d_all.deb (--unpack):
 dpkg-deb --control subprocess returned error exit status 2
Errors were encountered while processing:
 /__w/tarantool-python/tarantool-python/deb_dist/python3-tarantool_1.2.1.dev14+gec6001d_all.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to fix this.

Comment on lines 505 to 506
# https://github.com/yktoo/indicator-sound-switcher/issues/113#issuecomment-1243975728
# apt install zstd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Author

@patapenka-alexey patapenka-alexey Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unresolved problem with zstd at the packaging step under Ubuntu 24.04 and Debian 12. I still trying to find the solution.

Comment on lines 67 to 70
# Waiting until `checks` repo will be updated.
- name: Install old CMake
run: pip3 install cmake==3.15.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a link to the issue (and for other cases too).

@patapenka-alexey patapenka-alexey marked this pull request as draft April 3, 2025 05:44
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-1918-bump-ubuntu-version branch 3 times, most recently from e1cdbd0 to f2fa48c Compare April 3, 2025 07:37
@@ -8,3 +8,5 @@ flake8 == 6.1.0 ; python_version >= '3.8'
flake8 == 5.0.4 ; python_version < '3.8'
codespell == 2.3.0 ; python_version >= '3.8'
codespell == 2.2.5 ; python_version < '3.8'
setuptools >= 75.3.2
tarantool >= 1.2.0
Copy link
Author

@patapenka-alexey patapenka-alexey Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tarantool >= 1.2.0

hmmm... This should be removed, I think.

Bump actions to use ubuntu-24.04 for fixing the following GitHub
warning:

    The Ubuntu 20.04 Actions runner image will begin deprecation
    on 2025-02-01.

Additionally this patch updates test requirements, list of OSes
to test, hotfixes cmake 3.5 problem on latest Ubuntu and Debian.

Part of #TNTP-1918
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-1918-bump-ubuntu-version branch from 489108b to 3704614 Compare April 3, 2025 12:22
- bundle: 'sdk-gc64-2.11.0-0-r563.linux.x86_64'
path: 'release/linux/x86_64/2.11/'
python: ['3.7', '3.11']
python: ['3.11']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.9 is still supported:

https://devguide.python.org/versions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants