Remove join and subscribe & Release 1.0.0 #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change. Current join and subscribe implementations are rather useless. Connector does not provide any API to process incoming replication requests. The only supported scenario is to "connect as replica, skip everything that has been sent through replication, close on error". Current Tarantool team product strategy is to develop CDC features, including replication support in language connectors, as Enterprise edition products [1]. Since we don't plan to provide proper join and subscribe implementation in the open-source connector in the future, we decide to drop current half-baked implementation to not confuse new users. 1. tarantool/go-tarantool#203
Overview
This release introduces several minor behavior changes
to make API more consistent.
Starting from this release, connector no longer depends on `pandas`.
Breaking changes
- Allow only named `on_push` and `on_push_ctx` for `insert` and
`replace`.
- `tarantool.Datetime` `__repr__` has been changed.
- `tarantool.Datetime` input arguments are validated with
`datetime.datetime` rules.
- `tarantool.Datetime` is no longer expected to throw
`pandas.Timestamp` exceptions. `datetime.datetime` exceptions will
be thrown instead of them.
- Drop the support of `__eq__` operator of `tarantool.Datetime` for
`pandas.Timestamp`.
- Remove `join` and `subscribe` connection methods.
Changes
- Migrate to built-in `Warning` instead of a custom one.
- Migrate to built-in `RecursionError` instead of a custom one.
- Collect full exception traceback.
- Package no longer depends on `pandas` (#290).
Infrastructure
- Lint the code with `pylint`, `flake8` and `codespell`.
DifferentialOrange
force-pushed
the
DifferentialOrange/remove-replication
branch
from
1a8b637 to
7a42b5b
Compare
DifferentialOrange
changed the title
LeonidVas
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api: remove join and subscribe
This is a breaking change.
Current join and subscribe implementations are rather useless. Connector does not provide any API to process incoming replication requests. The only supported scenario is to "connect as replica, skip everything that has been sent through replication, close on error".
Current Tarantool team product strategy is to develop CDC features, including replication support in language connectors, as Enterprise edition products [1]. Since we don't plan to provide proper join and subscribe implementation in the open-source connector in the future, we decide to drop current half-baked implementation to not confuse new users.
Release 1.0.0
Overview
This release introduces several minor behavior changes
to make API more consistent.
Starting from this release, connector no longer depends on
pandas.Breaking changes
on_pushandon_push_ctxforinsertandreplace.tarantool.Datetime__repr__has been changed.tarantool.Datetimeinput arguments are validated withdatetime.datetimerules.tarantool.Datetimeis no longer expected to throwpandas.Timestampexceptions.
datetime.datetimeexceptions will be thrown instead of them.__eq__operator oftarantool.Datetimeforpandas.Timestamp.joinandsubscribeconnection methods.Changes
Warninginstead of a custom one.RecursionErrorinstead of a custom one.pandas(Make pandas dependency optional #290).Infrastructure
pylint,flake8andcodespell.