Update msgpuck to latest version and rework test cmake scripts#97
Merged
Totktonada merged 10 commits intotarantool:masterfrom Feb 8, 2019
Merged
Update msgpuck to latest version and rework test cmake scripts#97Totktonada merged 10 commits intotarantool:masterfrom
Totktonada merged 10 commits intotarantool:masterfrom
Conversation
Contributor
|
Please, see the travis status |
Contributor
|
We also need tarantool/msgpuck@222b71a (see here). |
Totktonada
reviewed
Feb 7, 2019
Totktonada
reviewed
Feb 7, 2019
Totktonada
reviewed
Feb 7, 2019
Contributor
|
Pushed a fix for tarantool-tcp.test.py (as a separate commit). |
Contributor
|
Pushed the fix for clang as a separate commit. We should squash it with your msgpuck update commit I think. |
The purpose of this commmit is to separate files needed for auto-tests
and manual tests (probably should be converted to autotests).
* cmake: use sourcedirs/bindirs(current/root) instead of relative
paths/project_source_dir variable,
* cmake: extract common test files to separate 'test_common' library,
* move tarantool-{tcp,poll} tests to cli subfolder and rewrite test
wrappers,
* rewrite `box.lua` with 'new' features (such as 'box.once' and 'LISTEN'
variable).
It is needed to catch -fPIC flag to build and link libmsgpuck.a statically from the submodule to easily build and test the connector. Dynamic linking under a cmake option is needed too for packaging, but is not implemented here. See tarantool#107 for more info. Closes tarantool#96. Needed for tarantool#107.
Totktonada
force-pushed
the
gh-96-latest-msgpuck
branch
from
e80cf07 to
6c6de89
Compare
Contributor
|
Rebased on top of the current master and removed the %zd → %lld change. Squashed fixup commits. |
Contributor
|
TBD: tarantool/msgpuck@e65e343 changes default build type. We need to set CMAKE_BUILD_TYPE to Debug before including msgpack in CMakeLists.txt. Update: it was fixed. |
OUTPUT_NAME is base name according to the documentation and should not be a full path. CMake 2.8.12.2 removes leading slash from it, so a build fails with 'No such directory' error. It works with CMake 3.13.3, however.
`make test` is still broken, but the connector builds.
Contributor
|
@bigbes Can you look into the PR? Now CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'Move around' files in the test folder
purpose of this commmit to separate files needed for auto-tests and
manual tests (probably should be converted to autotests)
relative paths/project_source_dir variable.
box.luawith 'new' features (such as 'box.once' and'LISTEN' variable)