Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link msgpuck statically when use the submodule #107

Open
Totktonada opened this issue Nov 9, 2018 · 2 comments
Open

Link msgpuck statically when use the submodule #107

Totktonada opened this issue Nov 9, 2018 · 2 comments
Labels
build
Milestone
wishlist

Comments

@Totktonada
Copy link
Member

Because trying to install libmsgpuck.so within a tarantool-c package can clash with system-wide msgpuck package.
@Totktonada
Copy link
Member Author

Totktonada commented Feb 7, 2019 •
edited
Loading

Subtask: #96.

@Totktonada
Copy link
Member Author

We should provide two options:

  • Build with statically linked libmsgpuck.a from the submodule.
  • Build with system-wide libmsgpuck.so.

The former should be default to easily build and test. The latter however is mandatory for packaging.

Totktonada pushed a commit to bigbes/tarantool-c that referenced this issue Feb 7, 2019
@bigbes @Totktonada
Update msgpuck submodule
6c6de89 
It is needed to catch -fPIC flag to build and link libmsgpuck.a
statically from the submodule to easily build and test the connector.
Dynamic linking under a cmake option is needed too for packaging, but is
not implemented here. See tarantool#107 for more info.

Closes tarantool#96.
Needed for tarantool#107.
@Totktonada Totktonada mentioned this issue Feb 7, 2019
Merged
Totktonada pushed a commit that referenced this issue Feb 8, 2019
@bigbes @Totktonada
Update msgpuck submodule
a116336 
It is needed to catch -fPIC flag to build and link libmsgpuck.a
statically from the submodule to easily build and test the connector.
Dynamic linking under a cmake option is needed too for packaging, but is
not implemented here. See #107 for more info.

Closes #96.
Needed for #107.
@kyukhin kyukhin added the build label Sep 17, 2021
@kyukhin kyukhin added this to the wishlist milestone Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
wishlist
Development

No branches or pull requests
2 participants
@Totktonada @kyukhin