comments for metrics #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
KaymeKaydex
reviewed
Apr 18, 2025
|
|
||
| for { | ||
| if spent := time.Since(requestStartTime); spent > timeout { | ||
| r.metrics().RequestDuration(spent, fnc, "", false, false) |
There was a problem hiding this comment.
Why we don`t send metric if request done with error?
There was a problem hiding this comment.
Because we decided to send metrics for particular requests to storage tarantools. This deleted code sends something else: aggregated metrics over several calls to different storage tarantools; also includes sleep time, timings to bucket_set/bucket_reset and etc. Finally, the aggregated timing can be measured by the caller outside of this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done? Why? What problem is being solved?
I didn't forget about (remove if it is not applicable):
Related issues: