Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add helpers for TcS #431

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Conversation

dmyger
Copy link

@dmyger dmyger commented Feb 24, 2025

Simple helpers to make easy create tests required Taranatool
centralized configuration storage.

@dmyger dmyger requested a review from oleg-jukovec February 25, 2025 15:47
@dmyger dmyger force-pushed the dmyger/gh-no_update_test_helpers branch from 9258c33 to 5d605bc Compare February 25, 2025 17:56
@dmyger dmyger force-pushed the dmyger/gh-no_update_test_helpers branch 2 times, most recently from be8b7f7 to ecdfe05 Compare March 3, 2025 12:03
@dmyger dmyger marked this pull request as ready for review March 3, 2025 12:04
@dmyger dmyger force-pushed the dmyger/gh-no_update_test_helpers branch 17 times, most recently from 0a85048 to d4f313e Compare March 5, 2025 12:55
@dmyger dmyger force-pushed the dmyger/gh-no_update_test_helpers branch 2 times, most recently from 461bcb9 to 6892ef3 Compare March 6, 2025 12:50
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please. Let's resolve all comments:

CI: bump Ubuntu up to 22.04 -> ci: bump Ubuntu up to 22.04

We use "ci" in this repo as a label.

@dmyger dmyger force-pushed the dmyger/gh-no_update_test_helpers branch 2 times, most recently from a5fe280 to 214aa5c Compare March 7, 2025 13:05
@dmyger dmyger requested a review from oleg-jukovec March 7, 2025 13:07
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to the changelog into Changed section. We don't support backward compatibility of the test suite, but it would be nice to highlight the changes.

@dmyger dmyger force-pushed the dmyger/gh-no_update_test_helpers branch from 214aa5c to 3986672 Compare March 7, 2025 13:39
@dmyger dmyger force-pushed the dmyger/gh-no_update_test_helpers branch from 3986672 to 39c2ea6 Compare March 7, 2025 13:55
@oleg-jukovec oleg-jukovec requested review from DerekBum and removed request for patapenka-alexey March 7, 2025 14:55
Simple helpers to make easy create tests required Taranatool
centralized configuration storage.
@dmyger dmyger force-pushed the dmyger/gh-no_update_test_helpers branch from 39c2ea6 to bcc3fc9 Compare March 10, 2025 11:44
@dmyger dmyger requested a review from DerekBum March 10, 2025 11:44
@oleg-jukovec oleg-jukovec merged commit 09a9e01 into master Mar 10, 2025
26 checks passed
@oleg-jukovec oleg-jukovec deleted the dmyger/gh-no_update_test_helpers branch March 10, 2025 12:51
@oleg-jukovec oleg-jukovec mentioned this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants