Skip to content

Sandbox unit.cfg_errors test #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Sandbox unit.cfg_errors test #1285

merged 1 commit into from
Mar 3, 2021

Conversation

rosik
Copy link
Contributor

@rosik rosik commented Mar 3, 2021

Recently we've encountered a weird test behavior: a test (unit.upload from #1266) succeded when run alone, but failed in conjunction with unit.cfg_errors test. The reason is in monkeypatching and reloading of lua modules used there.

With this patch, all test functions are moved to a simple empty server and run over netbox (remote-control).

I didn't forget about

  • Tests
  • Changelog (unnecessary)
  • Documentation (unnecessary)

@rosik rosik requested a review from olegrok March 3, 2021 00:38
Recently we've encountered a weird test behavior: a test (`unit.upload`
from #1266) succeded when run alone, but failed in conjunction with
`unit.cfg_errors` test. The reason is in monkeypatching and reloading of
lua modules used there.

With this patch, all test functions are moved to a simple empty server
and run over netbox (remote-control).
@rosik rosik force-pushed the sandbox-unit-test branch from 6d8960c to 1293463 Compare March 3, 2021 00:39
Copy link
Contributor

@olegrok olegrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file at least an issue to luatest to have an ability to run unit tests in separate tarantool process. Currently it looks ugly.

@rosik rosik marked this pull request as ready for review March 3, 2021 12:48
@rosik
Copy link
Contributor Author

rosik commented Mar 3, 2021

Please file at least an issue to luatest to have an ability to run unit tests in separate tarantool process. Currently it looks ugly.

tarantool/luatest#122

@rosik rosik merged commit 44b27f5 into master Mar 3, 2021
@rosik rosik deleted the sandbox-unit-test branch March 3, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants