Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deps] update tap-parser to v18 #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Deps] update tap-parser to v18 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .github/workflows/node-tens.yml
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions .github/workflows/node-aught.yml → .github/workflows/node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
name: 'Tests: node.js < 10'
name: 'Tests: node.js'

on: [pull_request, push]

jobs:
tests:
uses: ljharb/actions/.github/workflows/node.yml@main
with:
range: '< 10'
range: '>= 20'
type: minors
command: npm run tests-only

node:
name: 'node < 10'
name: 'node >= 20'
needs: [tests]
runs-on: ubuntu-latest
steps:
Expand Down
7 changes: 3 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use strict';

var parser = require('tap-parser');
var assign = require('object.assign');
var Parser = require('tap-parser').Parser;

module.exports = function (opts, cb) {
if (typeof opts === 'function') {
Expand All @@ -11,7 +10,7 @@ module.exports = function (opts, cb) {
if (!opts) { opts = {}; }
if (opts.wait === undefined) { opts.wait = 1000; }

var p = parser();
var p = new Parser();
var seen = { plan: null, asserts: [] };
var finished = false;
var ended = false;
Expand All @@ -20,7 +19,7 @@ module.exports = function (opts, cb) {
finished = true;

p.on('complete', function (finalResult) {
cb(assign({}, finalResult, { asserts: seen.asserts }));
cb(Object.assign({}, finalResult, { asserts: seen.asserts }));
});
if (opts.wait && !ended) {
setTimeout(function () { p.end(); }, opts.wait);
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
"version": "0.0.3",
"description": "detect when tap output is finished",
"main": "index.js",
"engines": {
"node": "20 || >=22"
},
"dependencies": {
"object.assign": "^4.1.4",
"tap-parser": "^5.4.0"
"tap-parser": "^18.0.0"
},
"devDependencies": {
"@ljharb/eslint-config": "^21.0.0",
Expand All @@ -29,8 +31,6 @@
"testling": {
"files": "test/*.js",
"browsers": [
"ie/8",
"ie/9",
"firefox/latest",
"chrome/latest",
"safari/latest",
Expand Down
14 changes: 12 additions & 2 deletions test/all_ok.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,19 @@ test(function (t) {
comment: ''
},
failures: [],
skips: [],
todos: [],
time: null,
passes: undefined,
asserts: [ // Result instances
{ ok: true, id: 1, name: '(unnamed assert)' },
{ ok: true, id: 2, name: 'should be equal' }
{ ok: true, id: 1, name: '(unnamed assert)', fullname: '(unnamed assert)',
diag: null, buffered: false, tapError: null, skip: false, todo: false,
previous: null, plan: null, time: null, closingTestPoint: false
},
{ ok: true, id: 2, name: 'should be equal', fullname: 'should be equal',
diag: null, buffered: false, tapError: null, skip: false, todo: false,
previous: null, plan: null, time: null, closingTestPoint: false
}
]
}, 'results matches expected object');
});
Expand Down
14 changes: 12 additions & 2 deletions test/excess.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,19 @@ test(function (t) {
comment: ''
},
failures: [],
skips: [],
todos: [],
time: null,
passes: undefined,
asserts: [ // these are Result instances
{ ok: true, id: 1, name: 'first thing' },
{ ok: true, id: 2, name: 'second thing' }
{ ok: true, id: 1, name: 'first thing', fullname: 'first thing',
buffered: false, tapError: null, skip: false, todo: false,
previous: null, plan: null, diag: null, time: null, closingTestPoint: false
},
{ ok: true, id: 2, name: 'second thing', fullname: 'second thing',
buffered: false, tapError: null, skip: false, todo: false,
previous: null, plan: null, diag: null, time: null, closingTestPoint: false
}
]
}, 'results matches expected object');
});
Expand Down
21 changes: 18 additions & 3 deletions test/finished.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,26 @@ test(function (t) {
comment: ''
},
failures: [ // these are Result instances
{ ok: false, id: 2, name: 'should be equal', diag: { operator: 'equal', expected: 5, actual: 4 } }
{ ok: false, id: 2, name: 'should be equal', fullname: 'should be equal',
diag: { operator: 'equal', expected: 5, actual: 4 },
buffered: false, tapError: null, skip: false, todo: false,
previous: null, plan: null, time: null, closingTestPoint: false
}
],
skips: [],
todos: [],
time: null,
passes: undefined,
asserts: [ // these are Result instances
{ ok: true, id: 1, name: '(unnamed assert)' },
{ ok: false, id: 2, name: 'should be equal', diag: { operator: 'equal', expected: 5, actual: 4 } }
{ ok: true, id: 1, name: '(unnamed assert)', fullname: '(unnamed assert)',
diag: null, buffered: false, tapError: null, skip: false, todo: false,
previous: null, plan: null, time: null, closingTestPoint: false
},
{ ok: false, id: 2, name: 'should be equal', fullname: 'should be equal',
diag: { operator: 'equal', expected: 5, actual: 4 },
buffered: false, tapError: null, skip: false, todo: false,
previous: null, plan: null, time: null, closingTestPoint: false
}
]
}, 'results matches expected object');
});
Expand Down
21 changes: 18 additions & 3 deletions test/trailing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,26 @@ test(function (t) {
comment: ''
},
failures: [ // these are Result instances
{ ok: false, id: 2, name: 'should be equal', diag: { operator: 'equal', expected: 5, actual: 4 } }
{ ok: false, id: 2, name: 'should be equal', fullname: 'should be equal',
diag: { operator: 'equal', expected: 5, actual: 4 },
buffered: false, tapError: null, skip: false, todo: false,
previous: null, plan: null, time: null, closingTestPoint: false
}
],
skips: [],
todos: [],
time: null,
passes: undefined,
asserts: [ // these are Result instances
{ ok: true, id: 1, name: '(unnamed assert)' },
{ ok: false, id: 2, name: 'should be equal', diag: { operator: 'equal', expected: 5, actual: 4 } }
{ ok: true, id: 1, name: '(unnamed assert)', fullname: '(unnamed assert)',
diag: null, buffered: false, tapError: null, skip: false, todo: false,
previous: null, plan: null, time: null, closingTestPoint: false
},
{ ok: false, id: 2, name: 'should be equal', fullname: 'should be equal',
diag: { operator: 'equal', expected: 5, actual: 4 },
buffered: false, tapError: null, skip: false, todo: false,
previous: null, plan: null, time: null, closingTestPoint: false
}
]
}, 'results matches expected object');
});
Expand Down
Loading