Improve symbol analysis across imported Tamarin files#33
Open
nikstuckenbrock wants to merge 5 commits into
Open
Improve symbol analysis across imported Tamarin files#33nikstuckenbrock wants to merge 5 commits into
nikstuckenbrock wants to merge 5 commits into
Conversation
a95cd35 to
3dae436
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
This PR improves the analysis logic used by the plugin, especially for checks like
check_variable_is_defined_in_premise, which previously only considered symbols defined in the current document.Problem
The existing implementation only analyzed symbols from the active file. Symbols coming from imported files — or from files importing the current file — were not taken into account. This led to incomplete analysis and false diagnostics in projects that make use of
#import.Changes
The analysis pipeline has been updated as follows:
Workspace-wide parsing on activation
Reverse import lookup
Incremental updates
Result
Checks such as
check_variable_is_defined_in_premisecan now resolve symbols across imports, resulting in more accurate diagnostics in the future.Let me know what you think.