feat: add search and sortable columns to machines list #377
+330
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add search input to filter machines by name or IP address - Add sortable column headers for Name, IP, Version, and Last Seen - Sort IP addresses numerically by octets (not alphabetically) - Sort versions numerically by segments (1.10.0 > 1.9.0) - Sort Last Seen with online machines treated as most recent - Add time delta display for offline machines (e.g., "2 days ago") - Add machine count display showing filtered/total counts - Add clear button (X) to search input Closes tale#351
tale
requested changes
Dec 4, 2025
| * - Under 1 month: "X days, Y hours ago" | ||
| * - Over 1 month: "X months, Y days ago" | ||
| */ | ||
| function formatTimeDelta(lastSeen: Date): string { |
Owner
There was a problem hiding this comment.
Can we move this to the utils folder? It might end up getting used on other things.
Contributor
Author
There was a problem hiding this comment.
Done! Good idea. There are actually a couple other functions that might be nice in shared utils:
IP sorting logic
Version comparison
Last seen comparison
But I kept this change to what you requested and we can tackle the rest as needed
Owner
|
Overall, this is such a welcome change, thank you so much for making this PR! It sets up a good future for replicating the search functionality that Tailscale provides. |
Moves the formatTimeDelta helper function to app/utils/time.ts for reusability across the codebase, as requested in PR review.
tale
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds search and sort functionality to the machines list page.
Changes
Screenshots
The UI follows existing patterns in the codebase. Column headers show chevron indicators for sort direction.
Closes #351