Skip to content

Add more folders to the list of ignored content dirs #17892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented May 6, 2025

Closes #15452

This PR adds more directories to the list of ignored content dirs. These are now handled the same as node_modules:

  • Contents of this directory are ignored by default to avoid scanning dependency trees
  • Explicit @imports inside these folders are now treated as external, bypassing any .gitignore files.

The new extensions are:

  • Version control systems: .hg, .svn
  • Bundler caches: .venv, venv, .yarn
  • Framework caches: .next, .turbo, .parcel-cache, __pycache__, .svelte-kit

Test plan

Verified with the repro of #15452 by renaming the ignored directory to .venv and installing a local tarball:

Screenshot 2025-05-06 at 13 14 55

@philipp-spiess philipp-spiess force-pushed the fix/venv-ignored-content-dir branch from 9da7a2d to d6dafcb Compare May 6, 2025 11:19
@philipp-spiess philipp-spiess marked this pull request as ready for review May 6, 2025 11:19
@philipp-spiess philipp-spiess requested a review from a team as a code owner May 6, 2025 11:19
@thecrypticace
Copy link
Contributor

Take a look at this one: tailwindlabs/tailwindcss-intellisense#1336

I'm adding these to IntelliSense as well — I've gotta add .svelte-kit to that list too. Maybe worth unifying these lists?

@philipp-spiess
Copy link
Member Author

@thecrypticace haha yep, let's unify these!

@philipp-spiess philipp-spiess force-pushed the fix/venv-ignored-content-dir branch from d6dafcb to aa5c889 Compare May 7, 2025 15:40
@philipp-spiess philipp-spiess changed the title Add .venv/venv to the list of ignored content dirs Add more folders to the list of ignored content dirs May 7, 2025
@philipp-spiess
Copy link
Member Author

@thecrypticace Updated! WDYT?

Copy link
Contributor

@thecrypticace thecrypticace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I like it 💯

@philipp-spiess philipp-spiess merged commit 179e5dd into main May 8, 2025
7 checks passed
@philipp-spiess philipp-spiess deleted the fix/venv-ignored-content-dir branch May 8, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tailwind v4 @source directive ignores subdirectories with .gitignore
2 participants