Fix touch actions on iOS after entering disallowed area #3801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, when you were scrolling or interacting with an open dialog on iOS, then the moment you scroll we check whether you're allowed to or not. Scrolling inside the Dialog is fine, outside is not. One thing we did is if you are outside, we use `touch-action: 'none'`. The problem is that we never reset this value while the dialog is open. This results in an issue where you cannot interacting with the Dialog later. This change makes sure that every `touchstart` event, we reset the `overscroll-behavior` and `touch-action` properties so we can start fresh.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
RobinMalfait
commented
Sep 19, 2025
| } | ||
| d.group((_d) => { | ||
| d.addEventListener(doc, 'touchstart', (e) => { | ||
| _d.dispose() |
There was a problem hiding this comment.
If you look at this change with ?w=1 then the only real code that changed here is that we wrap everything in a d.group so we have a new set of disposables to work with.
Every time a touchstart event fires, we dispose the local set of disposables and start over.
This is a local set of disposables so we don't dispose any other styles that were set or event listeners that should still listen for events.
thecrypticace
approved these changes
Sep 19, 2025
This was referenced Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where if you have an open Dialog on iOS that once you interacted with an area otuside of the dialog, you could no longer scroll or zoom the dialog itself anymore until it closed and reopened.
The reason this was happening is that on
touchstartwe checked whether we are in an allowed area or not.overscroll-behavior: containto the scrollable area to prevent scrolling the body behind it.touch-action: noneto the element you were touching to prevent any other touch events from being fired.The problem with this is that we never reset the state until the dialog is closed (and eventually unmounted).
So to solve the problem, every time we get a
touchstartevent, we reset those CSS properties to their previous values, and then check again whether we are in an allowed area or not.Note: the
touchstartevent listener is set on the document itself, so we still get the event even iftouch-action: nonewas set on the target element.Test plan
Made 2 videos with a before / after comparison. The reproduction used is from #3234. The steps I'm applying here are:
Before:
bad.mp4
After:
good.mp4
Fixes: #3234
Closes: #3602