-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added data_tailscale_acl data source #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just a couple of minor comments here.
fb9ccd1
to
8df9f36
Compare
anything you need from me to get this moving? thanks |
It seems that CI checks are still failing. In this case I think what's missing is running |
8df9f36
to
e1fe427
Compare
e1fe427
to
58f46ab
Compare
I have updated the PR with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What this PR does / why we need it:
there is currently no acl data_source which makes working with the acl hard
Which issue this PR fixes (use
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged):Fixes #180
Special notes for your reviewer:
I decided to expose it as a json blob as writing a schema and mangling it into that schema at load time was a lot of work and I don't see the benefit.
resource "tailscale_acl"
takes a json string so it doesn't seem unreasonable that the data source for that would give a json string tooAlso the external script I've been using up till now also works by providing a json string, which makes this a drop in replacement for that.
It works quite well with this test
P.s. sorry if the code's not great, it's the first go I've written so I have no idea about best practice etc