ts_tunnel: exchange names of Handshake and HandshakeState#159
Merged
Conversation
This makes the use of the exported type nicer, and also makes more sense internally: the internal type formerly called Handshake is the low-level state of the Noise protocol, not the overall handshake. Signed-off-by: David Anderson <danderson@tailscale.com> Change-Id: Ie3d21902b2b6beac707083098c17ac826a6a6964
npry
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the use of the exported type nicer, and also makes more sense internally: the internal type formerly called Handshake is the low-level state of the Noise protocol, not the overall handshake.
Change is a pure mechanical rename of two types, plus a rewording of the doctstring for Handshake. No other changes.