Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2652): improve argument names with llm #2787

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

laststylebender14
Copy link
Contributor

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #2652
/claim #2652

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@laststylebender14 laststylebender14 marked this pull request as draft September 3, 2024 15:29
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 69.88417% with 156 lines in your changes missing coverage. Please review.

Project coverage is 86.91%. Comparing base (d02b6e6) to head (6244ab4).
Report is 183 commits behind head on main.

Files with missing lines Patch % Lines
src/cli/llm/infer_arg_name.rs 48.70% 79 Missing ⚠️
src/core/async_transform.rs 0.00% 39 Missing ⚠️
src/cli/llm/async_presets.rs 0.00% 15 Missing ⚠️
src/cli/llm/infer_type_name.rs 0.00% 11 Missing ⚠️
src/core/config/transformer/rename_args.rs 96.92% 9 Missing ⚠️
src/cli/generator/generator.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2787      +/-   ##
==========================================
- Coverage   87.13%   86.91%   -0.23%     
==========================================
  Files         254      258       +4     
  Lines       25144    25702     +558     
==========================================
+ Hits        21910    22338     +428     
- Misses       3234     3364     +130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laststylebender14 laststylebender14 marked this pull request as ready for review September 4, 2024 16:32
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Sep 10, 2024
@laststylebender14 laststylebender14 marked this pull request as draft September 17, 2024 15:05
@laststylebender14 laststylebender14 marked this pull request as ready for review September 18, 2024 05:56
/// A configuration transformer that allows us to perform various
/// transformations on the configuration before it's further processed for
/// blueprint creation.
pub trait AsyncTransform {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make Transform support async transformations.

Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Sep 26, 2024
Copy link

github-actions bot commented Oct 1, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Oct 1, 2024
Copy link

github-actions bot commented Oct 7, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Oct 7, 2024
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Oct 12, 2024
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 17, 2024
@laststylebender14 laststylebender14 removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 23, 2024
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Oct 28, 2024
Copy link

github-actions bot commented Nov 2, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use LLMs to infer arg names of generated configurations
2 participants