Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legacy): add itemsHidden prop to tui-input-time #9908

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

splincode
Copy link
Member

Fixes #3519

@splincode splincode requested a review from a team as a code owner December 4, 2024 10:47
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 4, 2024 10:47
Copy link

lumberjack-bot bot commented Dec 4, 2024

Tests completed successfully ✅

Good job 🔥

@splincode splincode changed the title feat(legacy): add inputHidden to tui-input-time feat(legacy): add inputHidden prop to tui-input-time Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Visit the preview URL for this PR (updated for commit 0e73495):

https://taiga-previews-demo--pr9908-splincode-feat-issues-3519-ccc7ahwk.web.app

(expires Thu, 05 Dec 2024 10:55:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

@splincode splincode changed the title feat(legacy): add inputHidden prop to tui-input-time feat(legacy): add itemsHidden prop to tui-input-time Dec 4, 2024
Copy link

bundlemon bot commented Dec 4, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
303.8KB (+11B 0%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
259.99KB +10%
demo/browser/runtime.(hash).js
43.78KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +11B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.32MB (+81B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Playwright test results

passed  975 passed

Details

report  Open report ↗︎
stats  975 tests across 69 suites
duration  9 minutes, 11 seconds
commit  0e73495

documentationPropertyType="boolean"
[(documentationPropertyValue)]="itemsHidden"
>
Disable the display of the dropdown list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just use inject(TuiDropdownOpen, {optional: true}).tuiDropdownEnabled instead of creating new prop ? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🚀 - InputTime hide dropdown list items by settings flag
2 participants