Filter get endpoints #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 15, 2025 09:55
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
shahar4499
requested changes
Apr 15, 2025
Comment on lines
+333
to
334
| operation_methods: Dict[str, str] = {} | ||
| operations_by_tag: Dict[str, List[str]] = {} |
There was a problem hiding this comment.
naming consistency - if we have operations_by_tags already, call you dict operations_by_methods
| @@ -333,38 +341,58 @@ def _filter_tools(self, tools: List[types.Tool], openapi_schema: Dict[str, Any]) | |||
| operation_id = operation.get("operationId") | |||
| if not operation_id: | |||
| continue | |||
|
|
|||
| # Store the HTTP method for each operation ID | |||
There was a problem hiding this comment.
Too many redundant comments like these. I'm guessing that's Cursor noise. Please remove unless something really needs an explanation, otherwise it creates a resonance and LLMs will add more and more comments
| @@ -50,6 +51,7 @@ def __init__( | |||
| exclude_operations: List of operation IDs to exclude from MCP tools. Cannot be used with include_operations. | |||
| include_tags: List of tags to include as MCP tools. Cannot be used with exclude_tags. | |||
| exclude_tags: List of tags to exclude from MCP tools. Cannot be used with include_tags. | |||
| only_get_endpoints: If True, only expose GET endpoints. This filter is applied after other filters. | |||
There was a problem hiding this comment.
why have this very specific niche param? maybe instead be consistent with the rest of the API, and have include_methods and exclude_methods?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link (if applicable)
Screenshots of the feature / bugfix
Checklist before requesting a review