fix: union with parsedModules #2311
Conversation
| @@ -63,7 +65,11 @@ export function openContext( | |||
| parser: Parser, | |||
| parsedModules?: A.AstModule[], | |||
| ): CompilerContext { | |||
| const modules = parsedModules ?? parseModules(sources, parser); | |||
| const parsedSources = parseModules(sources, parser); | |||
There was a problem hiding this comment.
I would rather make parsedModules required, and pass parseModules(sources, parser) in regular build.
| // } | ||
| // } | ||
|
|
||
| function makeModule(): A.AstModule { |
There was a problem hiding this comment.
It seems like this should be a set of definitions in src/ast/no-src-factory.ts or even a reuse of existing code for this.
It will be extremely tedious to update manually in case AST definitions change. This code should eventually be generated from AST types.
There was a problem hiding this comment.
Agreed. I will migrate all the makeX functions into that new factory, because this will be a common problem in all PRs involving testing: each one of them defines their own makeX functions.
Is there an example on how to generate code for the makeX functions just from the AST types? Do you mean like a pre-compilation step, similar to yarn gen so that all makeX functions are generated?
There was a problem hiding this comment.
Actually, there was a AstUtil factory. I think I'll place the makeX functions there.
verytactical
changed the title
Issue
Closes #2310.
Checklist