✨ feat(meilisearch): 新增系统工作区及密钥和任务管理功能 - #6955
Merged
Merged
Conversation
- 增加 Meilisearch 系统概览、API 密钥管理与任务管理入口 - 支持密钥创建、查看、编辑、删除、复制及过期时间配置 - 新增索引和操作权限多选组件,并支持密钥列表列配置 - 在索引视图中新增任务页面导航
t8y2
requested changes
Aug 22, 2026
t8y2
left a comment
Owner
There was a problem hiding this comment.
Request changes。
-
apps/desktop/src/types/meilisearchManagement.ts:195的hasExplicitTaskSelector解构了未使用的key,exact-head frontend typecheck 失败:TS6133: 'key' is declared but its value is never read.请先修复该 typecheck blocker。 -
crates/dbx-core/src/db/meilisearch_driver.rs:1442的parse_key对所有密钥响应都强制要求存在明文key。API 密钥列表应能处理只返回 metadata、没有明文 secret 的响应;当前会导致/keys列表整体解析失败,而不是正常显示 UID、权限、索引和过期时间。请将创建响应与列表/详情响应的 secret 生命周期分开处理,并保持列表不传播明文密钥。
请修复后重新运行 frontend check 及相关 Meilisearch 测试。
t8y2
reviewed
Aug 22, 2026
t8y2
left a comment
Owner
There was a problem hiding this comment.
Maintainer patch pushed in 28ca7c2.
- Root cause: the task-selector helper destructured an unused
key, causing the frontend typecheck to fail. - Patch: ignore the unused tuple slot while preserving the selector-value logic.
- Validation:
meilisearchManagement.spec.ts(5/5),pnpm typecheck, andgit diff --checkall passed. - Correction: I rechecked the earlier
/keysresponse concern; that concern is withdrawn and is not a blocker for this PR.
t8y2
approved these changes
Aug 22, 2026
Owner
|
Thanks for the contribution! Merged in e55ee60, will be released in the next version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
新增 Meilisearch 系统管理工作区:
/metrics采集,避免实例未启用指标时带来兼容性问题。reverse任务参数,并防止管理任务轮询期间重复触发 mutation。变更类型
涉及前端
总览界面:
密钥:
task:
验证
make check通过(未运行)make cargo-check-fast通过(未运行)已执行:
pnpm exec vitest run ...MeilisearchTasksPage.spec.ts ...MeilisearchKeysPage.spec.ts ...meilisearchManagement.spec.ts ...meilisearchTaskColumns.spec.ts ...meilisearchKeyColumns.spec.tspnpm typecheckcargo fmt --checkcargo test -p dbx-core --lib meilisearch_driver::tests::task_selector_encodes_all_filters_and_cursor_safe_valuesgit diff --check关联 Issue