✨ feat(result-tabs): 支持固定结果标签及批量关闭操作 - #6954
Conversation
- 为结果标签和下拉选择器增加右键菜单,可固定、取消固定、关闭其他及关闭左右侧标签 - 固定结果在普通查询执行时不会被覆盖,必要时自动复用未固定标签或创建新标签 - 持久化固定状态,并完善结果快照恢复与淘汰场景处理 - 优化新增结果标签时的滚动位置,避免打断用户横向浏览 - 补充多语言文案与持久化测试
t8y2
left a comment
There was a problem hiding this comment.
Request changes。
-
:exact-head frontend CI 在 失败。执行新查询期间重新选择保留的结果后, 变成 ,测试期望 。请修复结果运行切换与 batch execution 状态投影之间的生命周期/状态保存问题。
-
当前 frontend CI 为 1 项失败(10813 项通过),请修复后重新运行完整 frontend check。
t8y2
left a comment
There was a problem hiding this comment.
Request changes。
-
apps/desktop/src/stores/queryStore.ts:exact-head frontend CI 在apps/desktop/src/stores/__tests__/queryStore.multiStatementError.spec.ts失败。执行新查询期间重新选择保留的结果后,batchSqlExecution.submittedSql变成undefined,测试期望SELECT 1 AS value。请修复结果运行切换与 batch execution 状态投影之间的生命周期/状态保存问题。 -
当前 frontend CI 为 1 项失败(10813 项通过),请修复后重新运行完整 frontend check。
t8y2
left a comment
There was a problem hiding this comment.
Maintainer patch pushed in 616a92c.
- Root cause: restoring a disk-backed result snapshot overlaid cleared in-memory payload fields, which erased
batchSqlExecutionstate when selecting a retained result during a new query. - Patch: overlay only the in-memory tab metadata and preserve the snapshot payload and execution state.
- Validation:
queryStore.multiStatementError.spec.ts,packages/app-tests/queryStore.test.ts,packages/app-tests/openTabsPersistence.test.ts,pnpm typecheck, andgit diff --checkall passed.
|
Thanks for the contribution! Merged in 93dc455, will be released in the next version. |
变更说明
变更类型
涉及前端
修复查询结果列表抖动问题。
原来:
现在:
验证
make check通过make cargo-check-fast通过已执行:
pnpm exec vitest run packages/app-tests/queryResultToolbar.test.ts packages/app-tests/queryStore.test.ts packages/app-tests/tabPresentation.test.tspnpm typecheckpnpm lintgit diff --check关联 Issue
Close #6058