change on node hard delete #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please look into this, same problem here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there.
I've encountered a trouble while deleting a node with destroy set to be true. After hard deletion the destroyed node can still be obtained by *func (MegaFS) PathLookup while not existing in mega server. So I dig into it and found the node will only be removed from hash table but still exists in its parent's children slice.
I made some change to handle this. But I am not sure whether the hard deletion you designed is meant to be used that way or something else. So plz check it when you are free. Anyway great appreciate for what you guys do for this fabulous tool.