-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(experimental): future module using taint #173
Open
juliusmarminge
wants to merge
2
commits into
main
Choose a base branch
from
taint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+139
−7
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,13 @@ | ||
import "./app/env.js"; | ||
// import "./app/env.js"; | ||
|
||
/** @type {import('next').NextConfig} */ | ||
const nextConfig = { | ||
eslint: { | ||
ignoreDuringBuilds: true, | ||
}, | ||
experimental: { | ||
taint: true, | ||
}, | ||
}; | ||
|
||
export default nextConfig; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,109 @@ | ||
/// <reference types="react/experimental" /> | ||
|
||
/** | ||
* This contains a potential future version of `createEnv` that | ||
* uses the new Taint API to prevent server variables from being | ||
* passed to client components. | ||
*/ | ||
|
||
import type { ServerClientOptions, StrictOptions } from "@t3-oss/env-core"; | ||
import { createEnv as createEnvCore } from "@t3-oss/env-core"; | ||
import * as React from "react"; | ||
import type { ZodType } from "zod"; | ||
|
||
const CLIENT_PREFIX = "NEXT_PUBLIC_" as const; | ||
type ClientPrefix = typeof CLIENT_PREFIX; | ||
|
||
type Options< | ||
TServer extends Record<string, ZodType>, | ||
TClient extends Record<`${ClientPrefix}${string}`, ZodType>, | ||
TShared extends Record<string, ZodType>, | ||
TExtends extends Array<Record<string, unknown>>, | ||
> = Omit< | ||
StrictOptions<ClientPrefix, TServer, TClient, TShared, TExtends> & | ||
ServerClientOptions<ClientPrefix, TServer, TClient>, | ||
"runtimeEnvStrict" | "runtimeEnv" | "clientPrefix" | ||
> & | ||
( | ||
| { | ||
/** | ||
* Manual destruction of `process.env`. Required for Next.js < 13.4.4. | ||
*/ | ||
runtimeEnv: StrictOptions< | ||
ClientPrefix, | ||
TServer, | ||
TClient, | ||
TShared, | ||
TExtends | ||
>["runtimeEnvStrict"]; | ||
experimental__runtimeEnv?: never; | ||
} | ||
| { | ||
runtimeEnv?: never; | ||
/** | ||
* Can be used for Next.js ^13.4.4 since they stopped static analysis of server side `process.env`. | ||
* Only client side `process.env` is statically analyzed and needs to be manually destructured. | ||
*/ | ||
experimental__runtimeEnv: Record< | ||
| { | ||
[TKey in keyof TClient]: TKey extends `${ClientPrefix}${string}` | ||
? TKey | ||
: never; | ||
}[keyof TClient] | ||
| { | ||
[TKey in keyof TShared]: TKey extends string ? TKey : never; | ||
}[keyof TShared], | ||
string | boolean | number | undefined | ||
>; | ||
} | ||
); | ||
|
||
export function createEnv< | ||
TServer extends Record<string, ZodType> = NonNullable<unknown>, | ||
TClient extends Record< | ||
`${ClientPrefix}${string}`, | ||
ZodType | ||
> = NonNullable<unknown>, | ||
TShared extends Record<string, ZodType> = NonNullable<unknown>, | ||
const TExtends extends Array<Record<string, unknown>> = [], | ||
>(opts: Options<TServer, TClient, TShared, TExtends>) { | ||
const client = typeof opts.client === "object" ? opts.client : {}; | ||
const server = typeof opts.server === "object" ? opts.server : {}; | ||
const shared = opts.shared; | ||
|
||
const runtimeEnv = opts.runtimeEnv | ||
? opts.runtimeEnv | ||
: { | ||
...process.env, | ||
...opts.experimental__runtimeEnv, | ||
}; | ||
|
||
const proxy = createEnvCore< | ||
ClientPrefix, | ||
TServer, | ||
TClient, | ||
TShared, | ||
TExtends | ||
>({ | ||
...opts, | ||
shared, | ||
client, | ||
server, | ||
clientPrefix: CLIENT_PREFIX, | ||
runtimeEnv, | ||
}); | ||
|
||
for (const key in proxy) { | ||
if (key in server) { | ||
try { | ||
React.experimental_taintUniqueValue( | ||
"Passing server variables is not supported", | ||
proxy, | ||
proxy[key], | ||
); | ||
} catch {} | ||
} | ||
} | ||
|
||
return proxy; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't import here since taint isn't "defined" yet