Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent start-database.sh from creating .env-e, fixes #2060 #2061

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maieutiquer
Copy link

@maieutiquer maieutiquer commented Feb 22, 2025

Closes #2060

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

fix start-database.sh to not create an .env-e file, which is not gitignored, thus preventing exposure of auth secret, fixes #2060


Screenshots

before:
image

after:
image

💯

Copy link

changeset-bot bot commented Feb 22, 2025

🦋 Changeset detected

Latest commit: 71ee726

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2025 2:18pm

Copy link

vercel bot commented Feb 22, 2025

@maieutiquer is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@maieutiquer maieutiquer changed the title Fix start database creating env e file fix: prevent start-database.sh from creating .env-e, fixes #2060 Feb 22, 2025
@maieutiquer maieutiquer changed the title fix: prevent start-database.sh from creating .env-e, fixes #2060 prevent start-database.sh from creating .env-e, fixes #2060 Feb 22, 2025
@maieutiquer maieutiquer changed the title prevent start-database.sh from creating .env-e, fixes #2060 fix: prevent start-database.sh from creating .env-e, fixes #2060 Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: start-database.sh creates non-ignored .env-e file with exposed AUTH_SECRET on macOS
1 participant