Skip to content

fix: restore coil gap filling while preserving helix segmentation#25

Merged
t03i merged 3 commits intomainfrom
fix/coils
Jul 2, 2025
Merged

fix: restore coil gap filling while preserving helix segmentation#25
t03i merged 3 commits intomainfrom
fix/coils

Conversation

@t03i
Copy link
Owner

@t03i t03i commented Jul 2, 2025

Summary

Restores coil rendering between secondary structure elements that was broken by the helix segmentation preservation changes.

Problem

The recent helix segmentation fix removed coil gap filling logic, causing coil regions between helices and sheets to disappear from protein visualizations (particularly affecting 3FTx structures).

Solution

  • Restore coil gap filling between all secondary structure elements
  • Preserve original helix/sheet segmentation boundaries from DSSP/CIF parsing
  • Handle discontinuous chains properly with separate coil segments
  • Maintain backward compatibility with annotations and other systems

Changes

  • Core: Enhanced Chain.secondary_structure property to include comprehensive coil gap filling
  • Tests: Updated expectations to reflect restored coil coverage

Test Coverage

All 450 tests pass, confirming both coil rendering functionality and preserved segmentation behavior.

@t03i t03i merged commit 02d1a0d into main Jul 2, 2025
3 checks passed
@t03i t03i deleted the fix/coils branch July 2, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant