Fix helix segmentation preservation in secondary structure parsing#23
Merged
Fix helix segmentation preservation in secondary structure parsing#23
Conversation
Adjust tests to changed logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes visual artifacts in protein helix rendering by preserving original segmentation boundaries from DSSP/CIF files without merging adjacent secondary structure elements.
Problem
When visualizing tetrameric hemoglobin with inertia-based projection, individual chains were projecting to overlapping locations due to helix segments being incorrectly merged during secondary structure processing. Long continuous helix ranges caused visual clutter where distinct helix segments should have been preserved.
Solution
secondary_structureproperty to preserve original segmentation boundaries from DSSP/CIF parsingChanges
ChainclassTest Coverage
All 450 tests pass, confirming backward compatibility and proper functionality.
Impact