Dollar assertion fails trailing newline

t-regx · Jan 2, 2025 · 6b5e9ff · 6b5e9ff
1 parent d9af364
commit 6b5e9ff
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Regex/private.php b/src/Regex/private.php
@@ -8,7 +8,7 @@ function _denoted(string $message, string $pattern, int $offset): string {
 
 function _pcre_pattern(string $pattern, ?string $modifiers): string {
     $delimiter = \str_contains($pattern, '/') ? "\1" : '/';
-    return $delimiter . $pattern . $delimiter . $modifiers;
+    return $delimiter . $pattern . $delimiter . "D$modifiers";
 }
 
 function _unprefixed(string $string, string $prefix): string {

diff --git a/test/FunctionsTest.php b/test/FunctionsTest.php
@@ -78,4 +78,9 @@ public function afterRegexCall_phpState_isNotPolluted(): void {
         }
         $this->assertNull(\error_get_last());
     }
+
+    #[Test]
+    public function dollarAssertion_failsTrailingNewline(): void {
+        $this->assertFalse(re_test('foo$', "foo\n"));
+    }
 }