Skip to content

Allow wider range of bpm in drummloop #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonnius wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow wider range of bpm in drummloop #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44082f1
Allow wider range of bpms
jonnius Jul 28, 2018
5a019be
Make sure bpms cant become negative
jonnius Jul 28, 2018
9f5777c
Make bpm range relative to measured bpm
jonnius Nov 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/drumloopplayer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ DrumLoopPlayer::DrumLoopPlayer(const double &volume, QObject *parent) :
qDebug() << "SoundTouch library version" << SoundTouch::getVersionString();
#endif
connect(m_watcher, SIGNAL(finished()), this, SLOT(processFinished()));
qDebug() << "SoundTouch not available!";
}

DrumLoopPlayer::~DrumLoopPlayer()
Expand Down Expand Up @@ -75,12 +76,12 @@ int DrumLoopPlayer::originalBpm() const

int DrumLoopPlayer::minBpm() const
{
return m_measuredBpm - 11;
return 0.8*m_measuredBpm;
}

int DrumLoopPlayer::maxBpm() const
{
return m_measuredBpm + 9;
return 1.2*m_measuredBpm;
}

void DrumLoopPlayer::stop()
Expand Down