fix: xpath filter passed to get_changes #90
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an xpath is set then the sysrepo API already provides only filtered changes. Reapplying the filter doesn't work when the filter element is not part of the result. For example, the xpath "/ietf-interfaces:interfaces/interface[type='iana-if-type:ethernetCsmacd']/enabled" subscribes for changes of the 'enabled' leaf but 'type' is not part of the result, in which case get_changes(xpath + '//.', ...) will always be empty! Hence, leave root path empty when an xpath is set to avoid invalid filtering!
Author
|
Actually that change is also not that nice as then the caller always gets all changes and not only the ones he subscribed for. The proper solution is to not collect the changes for the user but rather pass the session to the callback as a parameter so that the usre can query the changes he actually wants, which may only be a subset of what he subscribed for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an xpath is set then the sysrepo API already provides only filtered changes. Reapplying the filter doesn't work when the filter element is not part of the result.
For example, the xpath "/ietf-interfaces:interfaces/interface[type='iana-if-type:ethernetCsmacd']/enabled" subscribes for changes of the 'enabled' leaf but 'type' is not part of the result, in which case get_changes(xpath + '//.', ...) will always be empty!
Hence, leave root path empty when an xpath is set to avoid invalid filtering!