Integrate function-related structures #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Apr 28, 2025
ChAoSUnItY
force-pushed
the
feat/func_integrate
branch
4 times, most recently
from
17bebd8 to
6eea13a
Compare
jserv
requested changes
May 2, 2025
Collaborator
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Rebase the latest master branch and resolve conflicts.
Since the introduction of SSA middle end, there exists 2 different usage of function-related structures that is heavily coupled, but used under different scenarios. This causes unnecessary confusions to anyone who tries to understand it, and makes maintenance costly. In this patch, "func_t" and "fn_t" are now integrated into "func_t", and related variables are renamed into "func" instead of "fd" or "fn" to keep naming consistency and avoid confusions to previous structures. Additionally, few comments are refined, and unused label definitions removed to keep codebase tidy.
ChAoSUnItY
force-pushed
the
feat/func_integrate
branch
from
6eea13a to
b83d08b
Compare
Collaborator
|
Thank @ChAoSUnItY for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the introduction of SSA middle end, there exists 2 different usages of function-related structures that is heavily coupled, but used under different scenarios. This causes unnecessary confusions to anyone who tries to understand it, and makes maintenance costly.
In this patch,
func_tandfn_tare now integrated intofunc_t, and related variables are renamed intofuncinstead offdorfnto keep naming consistency and avoid confusions to previous structures.Additionally, few comments are refined, and unused label definitions removed to keep codebase tidy.
Summary by Bito
This pull request integrates the `func_t` and `fn_t` structures into a single `func_t`, enhancing code clarity and maintainability. It standardizes variable names, refines comments, and removes unused label definitions, contributing to a cleaner and more organized codebase.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2