Replace ALIASES and CONSTANTS with hashmap #194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use existing hashmap utilities to replace ALIASES and CONSTANTS.
Previously, "find_alias" and "find_constant" performed linear searches (O(n)). With the hashmap, search time is reduced to O(1) on average.
Benchmark for ./src/main.c compilation
Before: /usr/bin/time -v ./out/shecc ./src/main.c
After: /usr/bin/time -v ./out/shecc ./src/main.c
Summary by Bito
This pull request introduces performance enhancements by replacing ALIASES and CONSTANTS arrays with hashmaps, optimizing search operations from O(n) to O(1). The changes include new hashmap variables and updates to related functions for improved efficiency.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2