Fix DTB conditional build regression #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only build DTB when ENABLE_SYSTEM=1 and ENABLE_ELF_LOADER=0, resolving DTC syntax errors that occur when building with ELF loader mode enabled, as CFLAGS_dt macros are only defined in kernel emulation mode. The DTB is only needed for Linux kernel emulation, not for ELF loader mode which loads bare-metal programs directly.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only build DTB when ENABLE_SYSTEM=1 and ENABLE_ELF_LOADER=0, resolving DTC syntax errors that occur when building with ELF loader mode enabled, as CFLAGS_dt macros are only defined in kernel emulation mode.
The DTB is only needed for Linux kernel emulation, not for ELF loader mode which loads bare-metal programs directly.
Summary by cubic
Build the DTB only in kernel emulation mode, and skip it in ELF loader builds to prevent DTC syntax errors. DTB is only needed for kernel emulation; ELF loader runs bare-metal programs.