Fix llvm-ar detection for macOS builds #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="Makefile">
<violation number="1" location="Makefile:121">
The fallback to the system `ar` when `llvm-ar` is not found can break LTO builds on non-macOS systems. When LTO is enabled with Clang (the default), `llvm-ar` is required to handle LLVM bitcode in object files. The system `ar` on platforms like Linux may not be LTO-aware, causing link-time failures when creating or using static libraries like `softfloat.a`.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
The original code unconditionally used llvm-ar with Clang, causing build failures on macOS where Apple Clang doesn't provide llvm-ar. When LTO is enabled with Clang, llvm-ar is required to handle LLVM bitcode in object files. System ar on Linux cannot process LLVM bitcode, leading to link-time failures when creating static libraries like 'softfloat.a'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original assumed that Clang always provides llvm-ar, which fails on macOS where Apple Clang is the default compiler but doesn't include llvm-ar. This causes build failures when ENABLE_EXT_F=1.
Add runtime detection using 'which llvm-ar' to check availability before using it. Falls back to system 'ar' when llvm-ar is not found, ensuring builds work correctly with both Apple Clang and Homebrew LLVM.
Summary by cubic
Fix macOS builds by detecting llvm-ar in the Makefile when ENABLE_EXT_F=1. Use llvm-ar if available; otherwise fall back to ar, so Apple Clang builds succeed and Homebrew LLVM remains supported.