Refine git hooks #303
Merged
Refine git hooks #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces ✓/✗ symbols with [ OK ]/[ FAIL ] for better compatibility. It also standardizes printf formatting in git pre-push hook, ensuring brackets display in normal color, only status text colored. Change-Id: I4ba4f74acd36895b415648fddd9d04a1498858e0
The commit-msg hook was incorrectly flagging Unicode symbols like ✓ and ✗ as "Chinese characters" due to improper locale handling with LC_ALL=C. It uses Python3 with proper Unicode regex '[\u4e00-\u9fff]' for accurate detection adds fallback logic for systems without Python3, filtering out known Unicode symbols from false positive matches. Change-Id: I9b6b446b8f6df7a4b081f51c53204d3c97274607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.