feat(alerts): add notify_on_acknwoledge, deprecated opts at notification channel level #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbonf
requested review from
airadier,
antonio-cuomo,
dkutsanov,
mateobur,
michelevergnano and
tembleking
as code owners
dbonf
force-pushed
the
move-nc-options-at-alert-level
branch
5 times, most recently
from
6102d98 to
a69f90c
Compare
…ion channel level
dbonf
force-pushed
the
move-nc-options-at-alert-level
branch
from
a69f90c to
fdd3d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notify_on_acknwoledgeon all alert resources, it should be used if one want to send a notification for an alert that has been manually acknowledged by a user;notify_when_okandnotify_when_resolvedon notification channel resources: users should define these behaviors at alert level now.technical note: to allow for boolean attributes with no default, we use the string type, enforcing "true" and "false" values, instead of boolean values, because with the current terraform sdk there is no way to distinguish "false" from no value defined.