при ошибке удаления не выкидывать войс из отслеживаемых#21
Merged
Conversation
чистим bot_created_channels/channel_creators и сохраняем channels.json только после успешного delete (или NotFound). при любой другой ошибке канал остаётся в отслеживаемых и фоновая очистка доберёт его позже. fixes #20
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
insvrg3ncy
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
закрывает #20
раньше check_and_cleanup_channel сначала убирал канал из bot_created_channels/channel_creators и сохранял channels.json, а потом звал delete. если delete падал с чем угодно кроме NotFound (5xx, ratelimit, отняли права), канал в дискорде оставался, а бот про него навсегда забывал.
теперь порядок обратный: сначала delete, и только при успехе (или NotFound) чистим состояние. при любой другой ошибке канал остаётся в отслеживаемых, фоновая очистка (cleanup_task раз в 10 минут) попробует удалить его снова.