Skip to content

[Pagination] Fix tests with the latest symfony/dependency-injection - #4206

Merged
Kocal merged 1 commit into
symfony:3.xfrom
nicolas-grekas:pagination-target-alias
Nov 3, 2026
Merged

Kocal merged 1 commit into
symfony:3.xfrom
nicolas-grekas:pagination-target-alias

Conversation

@nicolas-grekas

Copy link
Copy Markdown
Member
Q A
Bug fix? no
New feature? no
Deprecations? no
Documentation? no
Issues -
License MIT

symfony/symfony#67757 makes the hidden .PaginatorInterface $blog alias point to the paginator service directly, instead of to the PaginatorInterface $blogPaginator alias. The test now checks which service this alias resolves to, so that it passes with every supported version of DependencyInjection.

This is what makes the php (dev, 8.5) job fail on unrelated PRs, eg #3501.

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 3, 2026
@Kocal

Kocal commented Nov 3, 2026

Copy link
Copy Markdown
Member

Thank you @nicolas-grekas.

@Kocal
Kocal merged commit 81c24c8 into symfony:3.x Nov 3, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pagination Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants