Skip to content

Conversation

@ker0x
Copy link
Contributor

@ker0x ker0x commented Nov 4, 2025

Q A
Bug fix? yes
New feature? no
Deprecations? no
Documentation? no
Issues -
License MIT

This PR update the CSS class of the Button component according to official Shadcn documentation.

It also removes the as props and relies on the presence of an href attribute to determine which element to use.

@ker0x ker0x requested a review from Kocal as a code owner November 4, 2025 17:07
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed Bug Bug Fix Toolkit labels Nov 4, 2025
@ker0x ker0x force-pushed the fix/shadcn-button branch 2 times, most recently from 2223ecf to c901873 Compare November 4, 2025 17:18
@Kocal
Copy link
Member

Kocal commented Nov 4, 2025

Thanks Romain that's super appreciated! I'll take a good look at all of this tonight :)

@Kocal Kocal force-pushed the fix/shadcn-button branch from c901873 to 64e0078 Compare November 8, 2025 08:11
@Kocal
Copy link
Member

Kocal commented Nov 8, 2025

Hey, I was finally able to take some time on your contribution, I did few minor changes, but everything is good:

  1. I re-introduced the as tag, I prefer to make it explicit and this behavior is closer to asChild from React
  2. I modified some examples to reflect the current Shadcn's Button documentation

@Kocal
Copy link
Member

Kocal commented Nov 8, 2025

Thank you @ker0x.

@Kocal Kocal merged commit 7c4f5e6 into symfony:2.x Nov 8, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Bug Fix Status: Needs Review Needs to be reviewed Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants