[RFC] use singular folder pattern like other components codes #2743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smnandre
reviewed
May 16, 2025
| @@ -23,7 +23,7 @@ And (2) a template: | |||
|
|
|||
| .. code-block:: html+twig | |||
|
|
|||
| {# templates/components/Alert.html.twig #} | |||
| {# templates/component/Alert.html.twig #} | |||
There was a problem hiding this comment.
templates has a "s" marking plural, similarely here to me it should stay plural
smnandre
reviewed
May 16, 2025
| @@ -7,7 +7,7 @@ making it easier to render and re-use small template "units" - like an | |||
|
|
|||
| Every component consists of (1) a class:: | |||
|
|
|||
| // src/Twig/Components/Alert.php | |||
| // src/Twig/Component/Alert.php | |||
There was a problem hiding this comment.
Suggested change
| // src/Twig/Component/Alert.php | |
| // src/Twig/Component/Alert.php |
Something we will discuss in 3.0 .. but i totally agree.
To be fair, i even think we should use src/Component
smnandre
reviewed
May 16, 2025
|
top for php file and ok for twig file makes sens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opening this PR mostly as RFC
other code in sf document to create special code (messenger message, event listener|subscriber, etc) inside folders in singular form not plural
does It makes sens for twig component to follow this pattern ?