Skip to content

[Twig] Improve Parser exceptions (minor) #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from
Open

[Twig] Improve Parser exceptions (minor) #2729

wants to merge 3 commits into from

Conversation

smnandre
Copy link
Member

Improves Parser exception

Throw a SyntaxError instead of a LogicError in ComponentParser

(following Twig #4601 : twigphp/Twig#4601)

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label May 11, 2025
@smnandre
Copy link
Member Author

(failures unrelated, PR already opened to handle them)

@smnandre smnandre requested review from kbond and Kocal May 11, 2025 23:04
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smnandre @kbond @Kocal @carsonbot